Skip to content

Add support for a multi-zone volumeHandle #1593

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 16, 2024
Merged

Add support for a multi-zone volumeHandle #1593

merged 1 commit into from
Feb 16, 2024

Conversation

pwschuurman
Copy link
Contributor

What type of PR is this?
/kind feature

What this PR does / why we need it:
A pattern in Kubernetes Deployment workloads is to use a single ROX PV, in the pod volumes template. When running a Deployment that runs in multiple zones, a user may want to leverage content backed on a PD. This PR adds support for "multi-zone" volumeHandles, allowing the PDCSI to interpret this as a placeholder the zone that a compute instance is running in.

Which issue(s) this PR fixes:
Fixes #1591

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Add support for multi-zone volumeHandle

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. labels Feb 8, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pwschuurman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Feb 8, 2024
@pwschuurman
Copy link
Contributor Author

/assign @msau42

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Feb 8, 2024
@pwschuurman pwschuurman force-pushed the hdml-support-upstream branch 2 times, most recently from 8da30d8 to 29ad315 Compare February 8, 2024 20:13
@msau42
Copy link
Contributor

msau42 commented Feb 9, 2024

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 9, 2024
@pwschuurman
Copy link
Contributor Author

/retest

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 13, 2024
@pwschuurman pwschuurman force-pushed the hdml-support-upstream branch from 0b04e01 to c680caf Compare February 14, 2024 17:56
@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 14, 2024
@pwschuurman pwschuurman force-pushed the hdml-support-upstream branch from c680caf to ce16e09 Compare February 14, 2024 18:01
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Feb 14, 2024
@pwschuurman
Copy link
Contributor Author

/retest

@pwschuurman
Copy link
Contributor Author

/assign @mattcary

@mattcary
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Feb 16, 2024
@pwschuurman pwschuurman force-pushed the hdml-support-upstream branch from ce16e09 to 70148a9 Compare February 16, 2024 19:31
@k8s-ci-robot k8s-ci-robot removed lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Feb 16, 2024
@mattcary
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 16, 2024
@k8s-ci-robot k8s-ci-robot merged commit d69610c into kubernetes-sigs:master Feb 16, 2024
@amacaskill
Copy link
Member

/cherry-pick release-1.13

@k8s-infra-cherrypick-robot
Copy link

@amacaskill: #1593 failed to apply on top of branch "release-1.13":

Applying: Add support for a multi-zone volumeHandle
Using index info to reconstruct a base tree...
M	cmd/gce-pd-csi-driver/main.go
M	pkg/gce-pd-csi-driver/controller.go
M	test/e2e/tests/multi_zone_e2e_test.go
M	test/e2e/tests/resize_e2e_test.go
M	test/e2e/tests/single_zone_e2e_test.go
M	test/e2e/utils/utils.go
Falling back to patching base and 3-way merge...
Auto-merging test/e2e/utils/utils.go
Auto-merging test/e2e/tests/single_zone_e2e_test.go
Auto-merging test/e2e/tests/resize_e2e_test.go
Auto-merging test/e2e/tests/multi_zone_e2e_test.go
Auto-merging pkg/gce-pd-csi-driver/controller.go
Auto-merging cmd/gce-pd-csi-driver/main.go
CONFLICT (content): Merge conflict in cmd/gce-pd-csi-driver/main.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Add support for a multi-zone volumeHandle
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick release-1.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@pwschuurman pwschuurman mentioned this pull request Feb 20, 2024
Merged
pwschuurman added a commit to pwschuurman/gcp-compute-persistent-disk-csi-driver that referenced this pull request Feb 20, 2024
@pwschuurman
Merge branch 'release-1.13' into automated-cherry-pick-of-kubernetes-…
c9b2963 
…sigs#1593-upstream-release-1.13
pwschuurman added a commit to pwschuurman/gcp-compute-persistent-disk-csi-driver that referenced this pull request Feb 20, 2024
@pwschuurman
Merge branch 'release-1.13' into automated-cherry-pick-of-kubernetes-…
90bb1e6 
…sigs#1593-upstream-release-1.13
k8s-ci-robot added a commit that referenced this pull request Feb 20, 2024
@k8s-ci-robot
Merge pull request #1616 from pwschuurman/automated-cherry-pick-of-#1…
24280ad 
…593-upstream-release-1.13

Automated cherry pick of #1593: Add support for a multi-zone volumeHandle
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amacaskill amacaskill Awaiting requested review from amacaskill

@leiyiz leiyiz Awaiting requested review from leiyiz

Assignees

@msau42 msau42

@mattcary mattcary

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for multi-zone volumeHandles
6 participants
@pwschuurman @k8s-ci-robot @msau42 @mattcary @amacaskill @k8s-infra-cherrypick-robot